fix: add address encoding validation in TokenLib.finalizeTransfer#192
Open
Arvuno wants to merge 1 commit into
Open
fix: add address encoding validation in TokenLib.finalizeTransfer#192Arvuno wants to merge 1 commit into
Arvuno wants to merge 1 commit into
Conversation
Add _validateAddressEncoding() function that detects when a caller uses wrong (right-aligned) address encoding (bytes32(uint256(uint160(addr)))) instead of the correct left-aligned form (bytes32(bytes20(addr))). The validation is called at the start of finalizeTransfer() and uses a require statement with a clear error message (WrongAddressEncoding). This prevents silent mis-use where the address would be decoded incorrectly. Closes base#190
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation function to detect wrong (right-aligned) address encoding in TokenLib.finalizeTransfer and prevent silent misuse. Detects bytes32(uint256(uint160(addr))) vs correct bytes32(bytes20(addr)).